Jump to content
Chewett

Refactoring Progress

Recommended Posts

Disabled battle logging code for various players no longer under investigation

* Cleaned up a lot of old code
* All PHP5 mysql functions removed for PHP7
 56 files changed, 146 insertions(+), 1043 deletions(-)

Begun work on caching system needed for Flashless MD.
4 files changed, 93 insertions(+), 40 deletions(-)

Work with creature page and new caching system begun
 6 files changed, 32 insertions(+), 11 deletions(-)

Share this post


Link to post
Share on other sites

Started work on converting the right bar over so its easier to work with. Once this all works I will begin the flash elements on the sub pages.

Fixed undefined index problems
 2 files changed, 14 insertions(+), 6 deletions(-)
 
Moved achievements page to the new system
 12 files changed, 106 insertions(+), 35 deletions(-)

Final tweaks for lho tools
 3 files changed, 7 insertions(+), 14 deletions(-) 
 
Added new system to active top list
 4 files changed, 100 insertions(+), 32 deletions(-)

Share this post


Link to post
Share on other sites

very happy to see you are alive (unlike myself:))  ,

just a note, i installed Chrome fresh now and flash comes disabled by default , and also is "harder" to enable back. I think flashless md is big priority ..but also a nightmare i know. Most of whats needed is there ..and we might have to give up certain scenes..

Share this post


Link to post
Share on other sites
7 hours ago, Muratus del Mur said:

and we might have to give up certain scenes..

Let me make it clear to everyone.

I haven't spent months reworking MD to just "give up certain scenes". Fuck that. Today I have spent most of the day on MD and I feel with the new cache we are making miles of progress. Its faster and easier to share code across the Javascript Layer which will have major benefits coding it.

Worst case scenario, we rebuild specific scenes from the ground up. And thats literally the worst case.

Share this post


Link to post
Share on other sites

Found an exciting bug that made the inventory page reload every two seconds, forever! That really caused performance issues :D

A really good set of progress today along with fixing some really bad bugs similar to the one above.

Gonna go sleep now, dont feel so well atm :( 

Changelog for today:

Removed file that is no longer needed
 1 file changed, 16 deletions(-)
 
Cleaned up adventure page
 1 file changed, 36 deletions(-)
 
Cleaned and moved over adventure page
 1 file changed, 5 insertions(+), 5 deletions(-)

Moved over another adventure page
 1 file changed, 6 insertions(+), 15 deletions(-)
 
Fixed issue with [redacted]
 1 files changed, 1 insertions(+), 1 deletion(-)
 
Moved over [redacted] for [redacted]
 3 files changed, 128 insertions(+), 81 deletions(-)
 
Cleaned up [redacted]
 1 file changed, 6 insertions(+), 122 deletions(-)
 
Fixed up [redacted]
 1 file changed, 40 insertions(+), 72 deletions(-)
 
Fixed up dev status
 1 file changed, 5 insertions(+), 2 deletions(-)
 
Tweaked the dream page
 1 file changed, 4 insertions(+), 2 deletions(-)
 
Moved over friendtop to new system
 4 files changed, 59 insertions(+), 12 deletions(-)
 
Moved over global messaging system
 1 file changed, 8 insertions(+), 4 deletions(-)
 
Fixed heads control interface for to new system
 1 file changed, 123 insertions(+), 112 deletions(-)
 
Converted inventory to new system
 3 files changed, 237 insertions(+), 142 deletions(-)
 
Fixed issue with general string function that had a long standing bug
 1 file changed, 1 insertion(+), 1 deletion(-)
 
Moved over top item page to new system
 3 files changed, 72 insertions(+), 12 deletions(-)
 
Added [redacted] to list
 4 files changed, 70 insertions(+), 7 deletions(-)
 
configured new system for smarter caching options
 1 file changed, 3 insertions(+)
 
Moved over online page
 3 files changed, 53 insertions(+), 4 deletions(-)
 
Moved over [redacted]
 1 file changed, 4 insertions(+), 4 deletions(-)
 
 
 
 

Share this post


Link to post
Share on other sites

Today's Progress:

 Moved over the public inventory display and abstracted more common code
 7 files changed, 101 insertions(+), 86 deletions(-)
 
 Moved over publiclog
 3 files changed, 42 insertions(+), 36 deletions(-)
 
 Moved over publiclogs and questlogs
 2 files changed, 8 insertions(+), 6 deletions(-)
 
 Fixed up [redacted] page
 3 files changed, 39 insertions(+), 23 deletions(-)
 
 Added samedna page and improved others
 7 files changed, 82 insertions(+), 57 deletions(-)
 
 Added sameplace for new system
 4 files changed, 51 insertions(+), 6 deletions(-)
 
 Tweaked bar spells a little
 1 file changed, 8 insertions(+), 5 deletions(-)
 
 Tweaked tokens page
 2 files changed, 4 insertions(+), 3 deletions(-)
 
 Upgraded the webcam page
 3 files changed, 38 insertions(+), 14 deletions(-)
 
 removed bad page
 1 file changed, 27 deletions(-)
 
 [webpack c23fd939] Added the wishtop [redacted] stuff
 5 files changed, 64 insertions(+), 24 deletions(-)
 
 

Share this post


Link to post
Share on other sites

[2019-08-12 01:27:09 - Stage 14] Posted By Chewett 
New caching system in test with the right bar
Over the past week I have moved over the entire right bar set to use a new type of Javascript loading/caching called webpack.

It should provide us with a lot of functionality including, but not limited to:
* Minification - aka it parses all the JS and makes it smaller
* MVC - Allows easier abstraction of controller logic for better MVC
* Code sharing - Using ES6 modules and imports really makes code sharing easy
* Intelligent caching - The smart caching means that it will split files served based on static analysis of the codebase. This means it will intelligently group files that a user needs on all pages. This will result in fewer requests for Javascript and should speed up things.

This is quite a big change which will need more testing but it looks pretty good so far. Please test out the sidebar and report any issues. If over the next week everything looks good I will merge everything into MD's master code.

Once this is proven to be working I will start converting over the flash elements we haven't changed to use the new system. Once everything but the scenes are converted I will focus on them. 
 

Share this post


Link to post
Share on other sites

an "issue" i noticed so far is that the page auto scrolls to the top when you click an item, i'm not sure if it's intended but it's not how it behaved before, and it would stay at the same page location whe nyou used an item, so that multile items could be used quickly. I think that i prefer the old functionality in terms of the page location resetting, as i would try to use 2 or 3 items quickly before the page refresh.

i don't think this is a real problem in terms of how the feature functions, more of a difference to what was before that might bother some others.

 

edit: this is in regards to the recent sidebar changes and inventory things.

Edited by Syrian

Share this post


Link to post
Share on other sites
1 hour ago, Syrian said:

an "issue" i noticed so far is that the page auto scrolls to the top when you click an item, i'm not sure if it's intended but it's not how it behaved before, and it would stay at the same page location whe nyou used an item, so that multile items could be used quickly. I think that i prefer the old functionality in terms of the page location resetting, as i would try to use 2 or 3 items quickly before the page refresh.

i don't think this is a real problem in terms of how the feature functions, more of a difference to what was before that might bother some others.

 

edit: this is in regards to the recent sidebar changes and inventory things.

It was originally intended but was broken! This update fixed it but may not be what we want. Opinions are welcome

Share this post


Link to post
Share on other sites

Wow, you are on a coding marathon i see :D nice nice :)

 

What i meant about "giving up certain scenes" was that i am happy even with that compromise as long as the rest is usable. I was thinking of the puzzle scenes.

Of course if you have any sort of solution to that i would be more than happy, i just don't want you to hit a wall when it comes to flash to html conversion. 

 

Now that i am thinking, actionscript is pretty similar to javascript, and everything done in those scenes can be ported to js ..maybe i will try to do that or at least extract all the actionscript code from the old fla sources.

 

Just imagine md in html, would fully work on mobile/tablet ..the most important step towards a better layout :P

very few still look for browsergames from a pc , and in the upcomming years we will remain one of those few games that target just a small minority. Having it work on mobile (flashless) browsers could mean enormous boost, not just survival.

 

p.s the recent developments in my life (little baby girl) made me have a lot more time away from the pc and this makes me much more creative, i can't wait to share all my recent ideas for md with you :D

Share this post


Link to post
Share on other sites
2 minutes ago, Muratus del Mur said:

i just don't want you to hit a wall when it comes to flash to html conversion. 

"If you have an impossible problem, give it to an idiot. They are too stupid to know that it cant be solved"

:D *grins madly* :D

Share this post


Link to post
Share on other sites

MD Player Dummy + Armour converted to HTML5

image.png

 

This is my example testing page now added to MD. It needs minor tweaks to handle some bad armour but that will be Wednesday and possibly deployment Wednesday or Thursday depending how long that takes.

Added the new player model code
 9 files changed, 384 insertions(+), 1 deletion(-)
 
Tweaked how we handle the code when there is no css on the page
 1 file changed, 7 insertions(+), 1 deletion(-)
  

Big progress!

image.png

Share this post


Link to post
Share on other sites
47 minutes ago, Muratus del Mur said:

I was thinking of the puzzle scenes.

I have some ideas, all of the puzzles I am thinking of shouldnt pose too much of a problem. Will need a custom scene type but thats not hard.

Share this post


Link to post
Share on other sites

I was taking a closer look at the sidebar and I noticed a couple of minor things (see red "circles"). I compared with old screenshots and it seems most of them were always like this, but the ropes used to be aligned (don't really know if it's this update's fault) -- check the other screenie.

I know it's not a big deal, but I figured it wouldn't hurt reporting it here :)

interface.thumb.PNG.d0ad43f4a62162643b37a226f90e28d1.PNG

interface2.PNG.4b755c416beab602933dae57d4b2d9f3.PNG

 

Edited by Aelis

Share this post


Link to post
Share on other sites
18 hours ago, Aelis said:

I was taking a closer look at the sidebar and I noticed a couple of minor things (see red "circles"). I compared with old screenshots and it seems most of them were always like this, but the ropes used to be aligned (don't really know if it's this update's fault) -- check the other screenie.

I know it's not a big deal, but I figured it wouldn't hurt reporting it here :)

interface.thumb.PNG.d0ad43f4a62162643b37a226f90e28d1.PNG

interface2.PNG.4b755c416beab602933dae57d4b2d9f3.PNG

 

Thats not related but something to fix.I will do that thanks! :)

Share this post


Link to post
Share on other sites

Today I was out most of the day but I spent some time tonight working on the idle page. Its a relatively self-contained page which is ripe for moving over to the new system entirely.

Only some work has been done, I hope to do the rest tomorrow.

12 files changed, 453 insertions(+), 113 deletions(-)

Share this post


Link to post
Share on other sites

Oh yeah the other reason little progress was made was because I didn’t have power for most of today due to an outage, and when they put the area on a generator it kept being reset hourly losing power for minutes at a time :( not entirely conducive to programming with a laptop with no battery!

fingers crossed it’s all been fixed!

Share this post


Link to post
Share on other sites

 12 files changed, 254 insertions(+), 61 deletions(-)

Ann. 4733 - [2019-08-20 00:16:11 - Stage 14] - Permalink - Posted By Chewett  
Another Flash bites the dust - Idle page
Another page has been entirely converted to HTML5. The idle page now uses all HTML5 elements and all flash parts have been removed.

This now holds the player avatar, activity bar, and player model code all in HTML5. The avatar and activity bar was already converted but now it also uses the player model recently added to the game.

Another small step towards our flashless future.
Chewett

 

 

Share this post


Link to post
Share on other sites

Moved over logout to new webpack system
 3 files changed, 18 insertions(+), 11 deletions(-)
 
Minor tweaks to remove more warnings
 1 file changed, 2 insertions(+), 1 deletion(-)
 
 Begun transferring world map to html5
 5 files changed, 25 insertions(+), 6 deletions(-)
 

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...

  • Forum Statistics

    15,832
    Total Topics
    173,485
    Total Posts
  • Recently Browsing

    No registered users viewing this page.

  • Upcoming Events

    No upcoming events found
  • Recent Event Reviews

×
×
  • Create New...